🧹 Furniture: Complete the rename!
#1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
changed the base branch from
main
to
furniture/ditch-unnecessary-top-level-marketplace
anaulin
approved these changes
Mar 11, 2023
| - 'spec/models/membership_spec.rb' | ||
| - 'spec/models/room_spec.rb' | ||
| - 'spec/policies/room_policy_spec.rb' | ||
| - 'spec/requests/furniture_placements_controller_request_spec.rb' | ||
| - 'spec/requests/furnitures_controller_request_spec.rb' |
There was a problem hiding this comment.
You could just un-lint these 😉
There was a problem hiding this comment.
I was afeared of trying to do even more in this giganormoustrosity
There was a problem hiding this comment.
If you put it in a separate commit I won't object!
But up to you, fine either way.
Base automatically changed from
furniture/ditch-unnecessary-top-level-marketplace
to
main
March 11, 2023 02:52
zspencer
force-pushed
the
furniture/and-do-the-rename
branch
from
b655ddf
to
81be782
Compare
OK this is the second-to-last-step; the rename across everything! After this, I'll rename the table to `furnitures` and we are *done*
zspencer
force-pushed
the
furniture/and-do-the-rename
branch
from
81be782
to
a303942
Compare
zspencer
added a commit
that referenced
this pull request
Mar 11, 2023
- #1209 (comment) - #709 I don't really like the direction this pushes specs, but I can live with it. In particular, a single assert per request/response seems... excruciatingly slow. But there are other mechanisms we can explore to mitigate that as it gets out of hand.
zspencer
added a commit
that referenced
this pull request
Mar 11, 2023
- #1209 (comment) - #709 I don't really like the direction this pushes specs, but I can live with it. In particular, a single assert per request/response seems... excruciatingly slow. But there are other mechanisms we can explore to mitigate that as it gets out of hand.
zspencer
added a commit
that referenced
this pull request
Mar 11, 2023
- #1209 (comment) - #709 I don't really like the direction this pushes specs, but I can live with it. In particular, a single assert per request/response seems... excruciatingly slow. But there are other mechanisms we can explore to mitigate that as it gets out of hand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Furniture: Consolidate toFurnitureto prep to dropFurniturePlacement #1208Gizmos #709OK, so I think this is a straight-up-rename; but there may be stuff that wants fixing...